Skip to content

[ZT] rework session management page #21865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2025
Merged

[ZT] rework session management page #21865

merged 4 commits into from
Apr 22, 2025

Conversation

@ranbel
Copy link
Contributor

@ranbel ranbel commented Apr 21, 2025

PCX-16297
PCX-16775

@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Apr 21, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

PR Change Summary

Reworked the session management documentation to clarify session durations and their configurations.

  • Updated section titles for clarity, including changing 'Session duration' to 'Session durations'.
  • Expanded explanations of global, policy, and application session durations with new analogies and examples.
  • Added detailed steps for configuring global and policy session durations in the Zero Trust dashboard.

Modified Files

  • src/content/docs/cloudflare-one/identity/users/session-management.mdx
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2025 •
edited
Loading

Preview URL: https://ee8e2976.preview.developers.cloudflare.com
Preview Branch URL: https://ranbel-session-duration.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/cloudflare-one/identity/users/session-management/ https://ranbel-session-duration.preview.developers.cloudflare.com/cloudflare-one/identity/users/session-management/

@jroyal
Copy link
Contributor

jroyal commented Apr 22, 2025

lgtm. The only thing I would add is that the default duration is 24 hours for everything if you don't set any specific duration.

@ranbel ranbel marked this pull request as ready for review April 22, 2025 15:14
@ranbel ranbel requested a review from a team as a code owner April 22, 2025 15:14
@ranbel ranbel mentioned this pull request Apr 22, 2025
Closed
marciocloudflare
marciocloudflare approved these changes Apr 22, 2025
View reviewed changes
@ranbel @marciocloudflare
Apply suggestions from code review
ee8e297 
Co-authored-by: marciocloudflare <[email protected]>
@ranbel ranbel enabled auto-merge (squash) April 22, 2025 17:00
@ranbel ranbel merged commit c55fbe2 into production Apr 22, 2025
12 checks passed
@ranbel ranbel deleted the ranbel/session-duration branch April 22, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennyj42 kennyj42 kennyj42 approved these changes

@marciocloudflare marciocloudflare marciocloudflare approved these changes

+1 more reviewer

@jroyal jroyal jroyal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kennyj42 kennyj42

Labels

product:cloudflare-one size/s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ranbel @jroyal @kennyj42 @marciocloudflare